Skip to content

Adding empty string check. #15 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Adding empty string check. #15 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed5f521
Adding empty string check. #15
kishorsharma May 16, 2016
05adeff
Replacing csv-stream with fast-csv as values with comma were not corr…
kishorsharma Jun 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ var path = require('path')
var chpro = require('child_process')

var through = require('through')
var csv = require('csv-stream')
var csv = require('fast-csv')
var osenv = require('osenv')
var duplexer = require('duplexer')
var concat = require('concat-stream')
Expand All @@ -33,12 +33,12 @@ module.exports = function (options) {
var write = fs.createWriteStream(filename)
.on('close', function () {
var child = spawn(require.resolve('j/bin/j.njs'), spawnArgs)
child.stdout.pipe(csv.createStream(options))
child.stdout.pipe(csv(options))
.pipe(through(function (data) {
var _data = {}
for(var k in data) {
var value = data[k].trim()
_data[k.trim()] = isNaN(value) ? value : +value
_data[k.trim()] = (isNaN(value) || value === '') ? value : +value;
}
this.queue(_data)
}))
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"dependencies": {
"JSONStream": "^1.0.4",
"concat-stream": "^1.4.6",
"csv-stream": "~0.1.3",
"duplexer": "~0.1.1",
"fast-csv": "^2.0.0",
"j": "^0.4.3",
"minimist": "^1.1.1",
"osenv": "^0.1.3",
Expand Down