Skip to content

Conversation

@anthony-redFox
Copy link
Member

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.098% when pulling 415eee1 on anthony-redFox:master into 4bb2047 on documentationjs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.098% when pulling 415eee1 on anthony-redFox:master into 4bb2047 on documentationjs:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.098% when pulling 415eee1 on anthony-redFox:master into 4bb2047 on documentationjs:master.

@anthony-redFox
Copy link
Member Author

anthony-redFox commented Dec 27, 2017

@tmcw I didn't add node version 4, I think we need to drop it.

Jest already drop support in 22.0 version
Node version 4 end life - April 2018 end life

@tmcw
Copy link
Member

tmcw commented Dec 29, 2017

Definitely, we should drop Node v4. Thanks for working on this, I'm pleasantly surprised that the tests pass on multiple versions!

@tmcw tmcw merged commit 27f75a9 into documentationjs:master Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants