Skip to content

Conversation

mvorisek
Copy link
Contributor

Some DBs allows multiple statements per single query and the formatter must support such syntax.

@mvorisek mvorisek marked this pull request as ready for review May 18, 2024 12:04
@mvorisek mvorisek marked this pull request as draft May 18, 2024 12:26
@mvorisek mvorisek marked this pull request as ready for review May 18, 2024 13:29
@mvorisek
Copy link
Contributor Author

@greg0ire can I have your review here? Thank you!

@greg0ire
Copy link
Member

Please squash your commits.

@mvorisek mvorisek force-pushed the fix_semicolon_toplevel branch from c251e22 to 0590175 Compare May 19, 2024 15:58
@mvorisek
Copy link
Contributor Author

mvorisek commented May 19, 2024

Squashed.

Once merged, please merge the 1.4.x into 1.5.x like in 4a151dd.

@greg0ire greg0ire added the bug Something isn't working label May 19, 2024
@mvorisek mvorisek requested a review from goetas May 20, 2024 08:42
@greg0ire greg0ire merged commit 51e2d67 into doctrine:1.4.x May 20, 2024
@greg0ire greg0ire added this to the 1.4.1 milestone May 20, 2024
@greg0ire
Copy link
Member

@mvorisek for some reason there are loads of conflicts, can you please send a PR to address them?

@mvorisek mvorisek deleted the fix_semicolon_toplevel branch May 20, 2024 20:59
@mvorisek
Copy link
Contributor Author

@greg0ire sure, here it is #114, please merge, I will then rebase #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants