Not enough parenthesis when using not() ?

[greg0ire]

I'm trying to link an article document with other articles. I'd rather not link an article with itself, so I try to write my first ODM query, with the helper in sonata admin :

$this->createQuery()
                            ->where()
                                ->not()
                                    ->same($this->getSubject()->getId(), 'a')
                                ->end()
                            ->end()
                        ->getQuery()

This produces the following query:

SELECT * FROM [nt:unstructured] AS a 
               WHERE (
                     NOT 
                           ISSAMENODE(a, ['/articles/mon deuxieme article']) 
                    AND 
                           (a.[phpcr:class] = 'Cine\DbBundle\Document\Article' OR a.[phpcr:classparents] = 'Cine\DbBundle\Document\Article'))

The AND operator seems to have higher priority because I can get what I want when trying the following request :

SELECT * FROM [nt:unstructured] AS a 
               WHERE (
                     (NOT 
                           ISSAMENODE(a, ['/articles/mon deuxieme article']) )
                    AND 
                           (a.[phpcr:class] = 'Cine\DbBundle\Document\Article' OR a.[phpcr:classparents] = 'Cine\DbBundle\Document\Article'))

Notice the extra couple of parenthesis.

1. I think this is a bug
2. I would like to know if I could somehow generate the second request with the query builder

[lsmith77]

@dantleech do you have a hint here?

[dantleech]

EDIT: actually that doesn't look correct, there would seem to be a bug

I have tried that QueryBuilder with both doctrine-dbal and jackrabbit and I get the following, which seems correct to me:

SELECT * FROM [nt:unstructured] AS a WHERE (NOT ISSAMENODE(a, [asd]) AND (a.[phpcr:class] = 'Doctrine\Tests\Models\Blog\User' OR a.[phpcr:classparents] = 'Doctrine\Tests\Models\Blog\User

using the same query in the following test:

    public function testSameAs()
    {
        $qb = $this->createQb();
        $qb->from('a')->document('Doctrine\Tests\Models\Blog\User', 'a')->end()
            ->where()
                ->not()
                    ->same('asd', 'a')
                ->end()
            ->end()
        ->getQuery();

        var_dump($qb->__toString());die();
    }

[greg0ire]

Could this get fixed by adding a couple of parenthesis here?

[dantleech]

@greg0ire exactly, I just made a PR: phpcr/phpcr-utils#128

[greg0ire]

Great! Closing this then, since I reported the issue in the wrong tracker. Thanks a lot for your reactivity!