Add rule forbidding more than one constant declared per statement #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although PSR only have this rule suggested to class properties, we enforce it for constants as well.
carusogabriel
commented
Apr 18, 2020
Comment on lines
14
to
+17
| public const BAZ = 456; | ||
|
|
||
| protected const PROPERTY_1 = '1'; | ||
| protected const PROPERTY_2 = '2'; |
Contributor
Author
There was a problem hiding this comment.
Spacing between constants will be proposed in a separate PR.
malarzm
approved these changes
Apr 18, 2020
ostrolucky
approved these changes
Apr 18, 2020
deeky666
approved these changes
Apr 18, 2020
greg0ire
approved these changes
Apr 18, 2020
Member
|
Thanks @carusogabriel ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although PSR only have this rule suggested to class properties, we
enforce it for constants as well.