Skip to content

Conversation

paulhibbitts
Copy link
Collaborator

@paulhibbitts paulhibbitts commented Aug 6, 2025

Summary

CSS updates for the following:

  • Fix for Coverpage title link colors
  • Fix for Transparent iframe support in dark mode
  • Fix for inline codeblock contrast within shaded table rows

Also available for review and testing in codesandbox:
https://codesandbox.io/p/sandbox/docsify-v5-css-issues-6r26v7

View index.html to uncomment related CSS fix to see proposed changes, etc.

And here is the same test Docsify site using the updated theme files in this PR:
https://paulhibbitts.github.io/docsify-v5-css-issues/#/

(not sure why clicking on Quick start on Coverpage only scrolls down halfway, I think this is a pretty recent issue and also seems to be on https://preview.docsifyjs.org/#/ now but not in RC-1 https://paulhibbitts.github.io/docsify-v5-rc-1-coverpage/)

Related issue, if any:

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

For any code change,

  • Related documentation has been updated, if needed
  • Related tests have been added or updated, if needed

Does this PR introduce a breaking change?

  • Yes
  • No

Tested in the following browsers:

  • Chrome
  • Firefox
  • Safari
  • Edge

Copy link

vercel bot commented Aug 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docsify-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2025 2:51am

Copy link
Member

@sy-records sy-records left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

not sure why clicking on Quick start on Coverpage only scrolls down halfway

I was unable to reproduce the issue. I reproduced it. I need to click on the title instead of the button.

@sy-records sy-records changed the title CSS updates for coverpage, iframe dark mode transparency and codeblock contast style: CSS updates for coverpage, iframe dark mode transparency and codeblock contast Aug 7, 2025
@sy-records
Copy link
Member

sy-records commented Aug 7, 2025

The cause of the problem is the anchor point. When clicked, it scrolls to the anchor point position, but # docsify <small>5.0.0-rc.1</small> generates id=docsify-500-rc1, which is located at this position.

@sy-records sy-records merged commit 5ac5a86 into docsifyjs:develop Aug 7, 2025
7 checks passed
@paulhibbitts
Copy link
Collaborator Author

Thank you very much @sy-records ! I will post a follow-up issue on the coverpage link question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants