Skip to content

Add sudo -E flag to curl command for proxy support #23604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −1
Open

Add sudo -E flag to curl command for proxy support #23604

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/manuals/engine/install/ubuntu.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ Docker from the repository.
sudo apt-get update
sudo apt-get install ca-certificates curl
sudo install -m 0755 -d /etc/apt/keyrings
sudo curl -fsSL {{% param "download-url-base" %}}/gpg -o /etc/apt/keyrings/docker.asc
sudo -E curl -fsSL {{% param "download-url-base" %}}/gpg -o /etc/apt/keyrings/docker.asc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if we should change this so that curl isn't executed as root;

curl -fsSL "{{% param "download-url-base" %}}/gpg" | sudo tee /etc/apt/keyrings/docker.asc > /dev/null

or with an intermediate file, but that requires a cleanup after;

curl -fsSL "{{% param "download-url-base" %}}/gpg" -o docker.asc
sudo install -o root -g root -m 0644 docker.asc /etc/apt/keyrings/docker.asc
rm -f docker.asc

@dvdksn @vvoland any thoughts? If we change, we should also update the debian.md accordingly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we previously agreed that sudo curl was an acceptable tradeoff - see https://github.com/docker/docs/pull/19138/files#r1467055019

I think sudo -E curl still seems OK to me but no strong opinions. If not sudo curl then I'd go for sudo tee > /dev/null

Copy link
Contributor

@vvoland vvoland Oct 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big deal I think, but if we want something shorter than tee we could use: sudo cat - >/etc/apt/keyrings/docker.asc

or sudo cat ->/etc/apt/keyrings/docker.asc if we want to be funny and use the cat goes to operator (which is a close relative to the "downto" operator in C)

sudo chmod a+r /etc/apt/keyrings/docker.asc

# Add the repository to Apt sources:
Expand Down