Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Jan 26, 2024

@netlify
Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 6dc6f50
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/65b3c8e090f3bc0008152ddf
😎 Deploy Preview https://deploy-preview-19232--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dvdksn dvdksn requested a review from thaJeztah January 26, 2024 14:27
@github-actions github-actions bot added the area/install Relates to installing a product label Jan 26, 2024
thaJeztah
thaJeztah previously approved these changes Jan 26, 2024
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

It looks like we may also be able to remove gnupg as pre-requisite; docker/docker-install#391

@dvdksn
Copy link
Contributor Author

dvdksn commented Jan 26, 2024

A good catch, let me remove it

@thaJeztah
Copy link
Member

At least; I don't think it's there for any reason other than that (I was curious at first, but my docker-install PR looked happy, and I tried it in a container and on a machine without gpg installed, and completed without issues (🎉)

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dvdksn
Copy link
Contributor Author

dvdksn commented Jan 26, 2024

yeah also tried a dind ubuntu install and it didnt complain without gnupg so should be good!

@dvdksn dvdksn merged commit 43ccf2a into docker:main Jan 26, 2024
@dvdksn dvdksn deleted the engine-install-chmod-gpg branch January 26, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/install Relates to installing a product

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants