Skip to content

Conversation

@tianon
Copy link
Contributor

@tianon tianon commented May 23, 2022

See https://tracker.debian.org/news/1305679/accepted-apt-240-source-into-unstable/:

* Install an empty /etc/apt/keyrings directory.
  This directory is intended to provide an alternative to
  /usr/share/keyrings for placing keys used with signed-by.

See also https://wiki.debian.org/DebianRepository/UseThirdParty?action=diff&rev2=47&rev1=46 (which was edited following a discussion with the APT maintainers about the expected usage):

If future updates to the key will be managed by an apt/dpkg package as recommended below, then it SHOULD be downloaded into /usr/share/keyrings using the same filename that will be provided by the package. If it will be managed locally , it SHOULD be downloaded into /etc/apt/keyrings instead.

See https://tracker.debian.org/news/1305679/accepted-apt-240-source-into-unstable/:

    * Install an empty /etc/apt/keyrings directory.
      This directory is intended to provide an alternative to
      /usr/share/keyrings for placing keys used with signed-by.

See also https://wiki.debian.org/DebianRepository/UseThirdParty?action=diff&rev2=47&rev1=46 (which was edited following a discussion with the APT maintainers about the expected usage):

> If future updates to the key will be managed by an apt/dpkg package as recommended below, then it SHOULD be downloaded into `/usr/share/keyrings` using the same filename that will be provided by the package. If it will be managed locally , it SHOULD be downloaded into `/etc/apt/keyrings` instead.

Signed-off-by: Tianon Gravi <[email protected]>
@netlify
Copy link

netlify bot commented May 23, 2022

Deploy Preview for docsdocker ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ec0809d
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/628bce2be7fe7d00085b8b5a
😎 Deploy Preview https://deploy-preview-14813--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@thaJeztah
Copy link
Member

Does that mean that potentially we can expect reports similar to docker/for-linux#1349 ?

@tianon
Copy link
Contributor Author

tianon commented May 23, 2022

Hmm, I don't think so -- that one looks like it's because we had both docker-ce.list and docker.list with different values.

@thaJeztah
Copy link
Member

Ah, right makes sense; I thought it would cache the previous value somewhere 👍

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit f99e132 into docker:master May 23, 2022
@tianon tianon deleted the etc/apt/keyrings branch May 23, 2022 18:52
Copy link
Contributor

@dockertopia dockertopia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acknowledged.

@thaJeztah
Copy link
Member

Opened docker/docker-install#294 to update the install script at get.docker.com to do the same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants