-
Notifications
You must be signed in to change notification settings - Fork 1.7k
test/integration: don't check for deprecated Networks field #3362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
thaJeztah
wants to merge
2
commits into
docker:main
Choose a base branch
from
thaJeztah:integration_deprecated_network
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+43
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ah, fun; probably test-certs / fixtures expired? Or something else?
|
the "integration-dind-ssl" tests were failing due to an issue with the test-certs created; ==================================== ERRORS ==================================== _________ ERROR at setup of BuildTest.test_build_container_with_target _________ /usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py:464: in _make_request self._validate_conn(conn) /usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py:1093: in _validate_conn conn.connect() /usr/local/lib/python3.12/site-packages/urllib3/connection.py:790: in connect sock_and_verified = _ssl_wrap_socket_and_match_hostname( /usr/local/lib/python3.12/site-packages/urllib3/connection.py:969: in _ssl_wrap_socket_and_match_hostname ssl_sock = ssl_wrap_socket( /usr/local/lib/python3.12/site-packages/urllib3/util/ssl_.py:480: in ssl_wrap_socket ssl_sock = _ssl_wrap_socket_impl(sock, context, tls_in_tls, server_hostname) /usr/local/lib/python3.12/site-packages/urllib3/util/ssl_.py:524: in _ssl_wrap_socket_impl return ssl_context.wrap_socket(sock, server_hostname=server_hostname) /usr/local/lib/python3.12/ssl.py:455: in wrap_socket return self.sslsocket_class._create( /usr/local/lib/python3.12/ssl.py:1041: in _create self.do_handshake() /usr/local/lib/python3.12/ssl.py:1319: in do_handshake self._sslobj.do_handshake() E ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: invalid CA certificate (_ssl.c:1010) During handling of the above exception, another exception occurred: /usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py:787: in urlopen response = self._make_request( /usr/local/lib/python3.12/site-packages/urllib3/connectionpool.py:488: in _make_request raise new_e E urllib3.exceptions.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: invalid CA certificate (_ssl.c:1010) Signed-off-by: Sebastiaan van Stijn <[email protected]>
These tests depended on the deprecated Spec.Networks field, which is no longer part of current API versions, causing the test to fail; =================================== FAILURES =================================== _____________ ServiceTest.test_create_service_with_custom_networks _____________ tests/integration/api_service_test.py:379: in test_create_service_with_custom_networks assert 'Networks' in svc_info['Spec'] E AssertionError: assert 'Networks' in {'Labels': {}, 'Mode': {'Replicated': {'Replicas': 1}}, 'Name': 'dockerpytest_a538894175d07404', 'TaskTemplate': {'Con...pec': {'Command': ['true'], 'Image': 'alpine:3.10', 'Isolation': 'default'}, 'ForceUpdate': 0, 'Runtime': 'container'}} ____________ ServiceTest.test_update_service_with_defaults_networks ____________ tests/integration/api_service_test.py:1128: in test_update_service_with_defaults_networks assert 'Networks' in svc_info['Spec'] E AssertionError: assert 'Networks' in {'Labels': {}, 'Mode': {'Replicated': {'Replicas': 1}}, 'Name': 'dockerpytest_6d8e30f359c0f5e', 'TaskTemplate': {'Cont...pec': {'Command': ['true'], 'Image': 'alpine:3.10', 'Isolation': 'default'}, 'ForceUpdate': 0, 'Runtime': 'container'}} _____________ ServiceTest.test_update_service_with_network_change ______________ tests/integration/api_service_test.py:1333: in test_update_service_with_network_change assert 'Networks' in svc_info['Spec'] E AssertionError: assert 'Networks' in {'Labels': {}, 'Mode': {'Replicated': {'Replicas': 1}}, 'Name': 'dockerpytest_d4e23667cdbaf159', 'TaskTemplate': {'Con... {'Command': ['echo', 'hello'], 'Image': 'busybox', 'Isolation': 'default'}, 'ForceUpdate': 0, 'Runtime': 'container'}} ------- generated xml file: /src/bundles/test-docker-py/junit-report.xml ------- =========================== short test summary info ============================ Signed-off-by: Sebastiaan van Stijn <[email protected]>
bf0998c
to
c7ab647
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests depended on the deprecated Spec.Networks field, which is no longer part of current API versions, causing the test to fail;