Skip to content

Conversation

@akx
Copy link
Contributor

@akx akx commented Dec 21, 2023

This PR switches the packaging for docker-py from the old and busted setup.cfg + setup.py stuff to PEP517 Hatch's hatchling and the hatch-vcs plugin to provide what setuptools_scm did.

Aside from superficial changes in metadata structure (and file times being static for more reproducible builds), the resulting wheels are the same (and of course the _version file is different because there's two extra commits here...):

comp1

There's also an added GitHub Actions workflow that builds the wheel even when not publishing, so you can look at the results for any given PR.

Note

This PR includes #3205 – it drops packaging out of the requirements.

@akx akx force-pushed the modernize-build branch 2 times, most recently from 802838f to 854dd83 Compare December 21, 2023 08:52
@milas milas self-assigned this Jan 3, 2024
@akx akx force-pushed the modernize-build branch from 854dd83 to 047df6b Compare January 3, 2024 19:20
Copy link
Contributor

@milas milas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A HUGE thanks from me, this is long overdue and looks great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants