Skip to content

Improve error message in case of paramiko failure #2252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Improve error message in case of paramiko failure #2252

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f919610
Improve error message in case of paramiko failure
ssbarnea Feb 9, 2019
1848bb6
Update client.py
ssbarnea Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions docker/api/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,10 @@ def __init__(self, base_url=None, version=None,
self._custom_adapter = SSHAdapter(
base_url, timeout, pool_connections=num_pools
)
except NameError:
except NameError as e:
# do not hide orriginal exception as it may contain important info
Copy link
Contributor

@ulyssessouza ulyssessouza Mar 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: orriginal -> original

raise DockerException(
'Install paramiko package to enable ssh:// support'
"Paramiko failure while trying ssh:// protocol:\n%s" % e
Copy link
Contributor

@ulyssessouza ulyssessouza Mar 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if changing the message is necessary here.

)
self.mount('http+docker://ssh', self._custom_adapter)
self._unmount('http://', 'https://')
Expand Down