Skip to content

Conversation

@thombashi
Copy link
Contributor

The default value of the version of APIClient described as 1.30 in the docker-py document.
However, it is actually 1.35.
self._version assigned DEFAULT_DOCKER_API_VERSION if passing None to version, and its value is 1.35

DEFAULT_DOCKER_API_VERSION = '1.35'

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fix_api_ver_desc" [email protected]:thombashi/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

1.30 -> 1.35

Signed-off-by: Tsuyoshi Hombashi <[email protected]>
Copy link
Contributor

@shin- shin- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shin- shin- merged commit 61bab63 into docker:master Jan 26, 2019
@shin- shin- added this to the 4.0.0 milestone Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants