Skip to content

Conversation

@adaszko
Copy link

@adaszko adaszko commented Nov 22, 2018

This is to ease configuration of the logger in the applications code
that use the library. So instead of having to configure all the loggers
corresponding to various __name__s, it is enough to configure just one,
named docker-py.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "single-logger" [email protected]:adaszko/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@ulyssessouza
Copy link
Contributor

ulyssessouza commented Apr 4, 2019

This PR is not passing due to an already solved problem.
Please rebase your PR with master

#2307

This is to ease configuration of the logger in the applications code
that use the library.  So instead of having to configure all the loggers
corresponding to various '__name__'s, it is enough to configure just one,
named 'docker-py'.

Signed-off-by: Adam Szkoda <[email protected]>
@adaszko
Copy link
Author

adaszko commented Apr 5, 2019

Pushed but something in Jenkins is still failing.

@adaszko adaszko closed this May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants