Skip to content

Change permissions handling to be more conservative #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2015
Merged

Change permissions handling to be more conservative #74

merged 1 commit into from
Apr 21, 2015

Conversation

@tianon
Copy link
Member

@tianon tianon commented Apr 21, 2015

This allows things like bind-mounting into /var/www/html/wp-content/themes/example and not clobbering host permissions, making theme development and testing much simpler (change PHP file on host, reload page, etc).

@tianon
Change permissions handling to be more conservative
d7be0b1 
This allows things like bind-mounting into `/var/www/html/wp-content/themes/example` and not clobbering host permissions, making theme development and testing much simpler (change PHP file on host, reload page, etc).
@tianon
Copy link
Member Author

tianon commented Apr 21, 2015

Essentially, we chown the content we copy from instead of the copied content, so when the files get copied in they already have the correct permissions. Then we just have to clean up files we create afterwards which will be root:root.

@yosifkit
Copy link
Member

yosifkit commented Apr 21, 2015

LGTM

@yosifkit
Copy link
Member

yosifkit commented Apr 21, 2015

Needs docs 😉

@tianon
Copy link
Member Author

tianon commented Apr 21, 2015

Yeah.... Shhh 😉

tianon added a commit that referenced this pull request Apr 21, 2015
@tianon
Merge pull request #74 from infosiftr/conservative-permissions
f5e1554 
Change permissions handling to be more conservative
@tianon tianon merged commit f5e1554 into docker-library:master Apr 21, 2015
@tianon tianon deleted the conservative-permissions branch April 21, 2015 21:40
tianon added a commit to infosiftr/stackbrew that referenced this pull request Apr 21, 2015
@tianon
Update wordpress with conservative permissions change (docker-library…
ff32f3a 
…/wordpress#74)
@tianon tianon mentioned this pull request Nov 13, 2017
Merged
@tianon tianon mentioned this pull request Feb 28, 2020
Closed
@yosifkit yosifkit mentioned this pull request Jun 8, 2020
Closed
@tianon tianon mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tianon @yosifkit