Skip to content

Conversation

@guss77
Copy link

@guss77 guss77 commented Oct 17, 2015

refactor the additional PHP code for wp-config.php into a function to support more complicated setups, and implement support for setting WP_ALLOW_MULTISITE

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think including hebrew (or other languages) into the official image is something we should do. You can easily do this by building your own image FROM the official image and adding the language files there.

@tianon
Copy link
Member

tianon commented Apr 20, 2016

IMO, this is pretty similar to #8 (and I'm really sorry for the delay in responding 😞); my reservations about it would be the same as those I have on #8 -- it's not included in the default wp-config.php file, so our script gets even more fragile than it already is by trying to support these types of things (which are more easily and support-ably accomplished by "bring your own config" either through bind-mount or through a derived image FROM this one which modifies the sample config we source). I do think we could do with better documentation around customizing the WP install, especially with regards to wp-config.php but even things like themes (or using a bind-mount for quick and easy theme development, for example).

}
EOPHP
[ -n "$WP_ALLOW_MULTISITE" ] && echo "define( 'WP_ALLOW_MULTISITE', true );"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is useful, but not necessary if docker-entrypoint.sh would allow pulling in external snippets (i.e. from /etc/wordpress/*.php).

Why is it not merged yet?

@tianon tianon closed this Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants