Skip to content

Conversation

@tianon
Copy link
Member

@tianon tianon commented Jul 31, 2017

@tianon
Copy link
Member Author

tianon commented Jul 31, 2017

(This change is pretty much identical to docker-library/python#215, minus the Windows bits.)

@yosifkit
Copy link
Member

yosifkit commented Aug 1, 2017

What is the verdict on stretch-slim and jessie-slim? I didn't see a written discussion in docker-library/python#215 and figured it will also come up on images later. What is the case for rejecting distro specific slim images?

I know we informally rejected the jessie-onbuild in golang since onbuild was being phased out.


Pros for jessie-slim

  • can follow specific Debian release just like regular ruby image
    • not forced to upgrade when default Debian distro changes in official images

Cons:

  • extra logic in generate-stackbrew
  • extra tags
-Tags: 2.4.1-slim, 2.4-slim, 2-slim, slim
+Tags: 2.4.1-jessie-slim, 2.4-jessie-slim, 2-jessie-slim, jessie-slim, 2.4.1-slim, 2.4-slim, 2-slim, slim

@tianon
Copy link
Member Author

tianon commented Aug 3, 2017

I think we discussed that briefly and determined that it ought to be slim-jessie, if we decide that's something we're OK with doing (to make it clear this is a "jessie" sub-variant of the "slim" variant), not necessarily something based on debian:jessie-slim (although in many cases might be).

@yosifkit
Copy link
Member

yosifkit commented Aug 3, 2017

That sounds right. Do we want to add them now, so that users will start specifying Debian release in their slim images too?

@tianon
Copy link
Member Author

tianon commented Aug 3, 2017

$ ./generate-stackbrew-library.sh
# this file is generated via https://github.com/docker-library/ruby/blob/05a198ca89a5cb563a857d0d6f060abcbd6eb8e4/generate-stackbrew-library.sh

Maintainers: Tianon Gravi <[email protected]> (@tianon),
             Joseph Ferguson <[email protected]> (@yosifkit)
GitRepo: https://github.com/docker-library/ruby.git

Tags: 2.4.1-jessie, 2.4-jessie, 2-jessie, jessie, 2.4.1, 2.4, 2, latest
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: a6918175fd506b46bf2d8f899f4faa40e72296fb
Directory: 2.4/jessie

Tags: 2.4.1-slim-jessie, 2.4-slim-jessie, 2-slim-jessie, slim-jessie, 2.4.1-slim, 2.4-slim, 2-slim, slim
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: a6918175fd506b46bf2d8f899f4faa40e72296fb
Directory: 2.4/jessie/slim

Tags: 2.4.1-onbuild, 2.4-onbuild, 2-onbuild, onbuild
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: a6918175fd506b46bf2d8f899f4faa40e72296fb
Directory: 2.4/jessie/onbuild

Tags: 2.4.1-alpine3.4, 2.4-alpine3.4, 2-alpine3.4, alpine3.4, 2.4.1-alpine, 2.4-alpine, 2-alpine, alpine
Architectures: amd64
GitCommit: a6918175fd506b46bf2d8f899f4faa40e72296fb
Directory: 2.4/alpine3.4

Tags: 2.3.4-jessie, 2.3-jessie, 2.3.4, 2.3
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: a6918175fd506b46bf2d8f899f4faa40e72296fb
Directory: 2.3/jessie

Tags: 2.3.4-slim-jessie, 2.3-slim-jessie, 2.3.4-slim, 2.3-slim
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: a6918175fd506b46bf2d8f899f4faa40e72296fb
Directory: 2.3/jessie/slim

Tags: 2.3.4-onbuild, 2.3-onbuild
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: a6918175fd506b46bf2d8f899f4faa40e72296fb
Directory: 2.3/jessie/onbuild

Tags: 2.3.4-alpine3.4, 2.3-alpine3.4, 2.3.4-alpine, 2.3-alpine
Architectures: amd64
GitCommit: a6918175fd506b46bf2d8f899f4faa40e72296fb
Directory: 2.3/alpine3.4

Tags: 2.2.7-jessie, 2.2-jessie, 2.2.7, 2.2
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: a6918175fd506b46bf2d8f899f4faa40e72296fb
Directory: 2.2/jessie

Tags: 2.2.7-slim-jessie, 2.2-slim-jessie, 2.2.7-slim, 2.2-slim
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: a6918175fd506b46bf2d8f899f4faa40e72296fb
Directory: 2.2/jessie/slim

Tags: 2.2.7-onbuild, 2.2-onbuild
Architectures: amd64, arm32v5, arm32v7, arm64v8, i386, ppc64le, s390x
GitCommit: a6918175fd506b46bf2d8f899f4faa40e72296fb
Directory: 2.2/jessie/onbuild

Tags: 2.2.7-alpine3.4, 2.2-alpine3.4, 2.2.7-alpine, 2.2-alpine
Architectures: amd64
GitCommit: a6918175fd506b46bf2d8f899f4faa40e72296fb
Directory: 2.2/alpine3.4

@tianon
Copy link
Member Author

tianon commented Aug 3, 2017

$ diff -u <(bashbrew list ruby | cut -d: -f2 | sort -V) <(bashbrew list <(./generate-stackbrew-library.sh) | cut -d: -f2 | sort -V)
--- /dev/fd/63	2017-08-03 14:09:00.478657126 -0700
+++ /dev/fd/62	2017-08-03 14:09:00.479657097 -0700
@@ -1,32 +1,56 @@
 2
 2-alpine
+2-alpine3.4
+2-jessie
 2-onbuild
 2-slim
+2-slim-jessie
 2.2
 2.2-alpine
+2.2-alpine3.4
+2.2-jessie
 2.2-onbuild
 2.2-slim
+2.2-slim-jessie
 2.2.7
 2.2.7-alpine
+2.2.7-alpine3.4
+2.2.7-jessie
 2.2.7-onbuild
 2.2.7-slim
+2.2.7-slim-jessie
 2.3
 2.3-alpine
+2.3-alpine3.4
+2.3-jessie
 2.3-onbuild
 2.3-slim
+2.3-slim-jessie
 2.3.4
 2.3.4-alpine
+2.3.4-alpine3.4
+2.3.4-jessie
 2.3.4-onbuild
 2.3.4-slim
+2.3.4-slim-jessie
 2.4
 2.4-alpine
+2.4-alpine3.4
+2.4-jessie
 2.4-onbuild
 2.4-slim
+2.4-slim-jessie
 2.4.1
 2.4.1-alpine
+2.4.1-alpine3.4
+2.4.1-jessie
 2.4.1-onbuild
 2.4.1-slim
+2.4.1-slim-jessie
 alpine
+alpine3.4
+jessie
 latest
 onbuild
 slim
+slim-jessie

@yosifkit yosifkit merged commit 32f9e3f into docker-library:master Aug 3, 2017
@yosifkit yosifkit deleted the explicit-jessie branch August 3, 2017 21:37
tianon added a commit to infosiftr/stackbrew that referenced this pull request Aug 3, 2017
- `php`: 7.1.8, 7.2.0beta2
- `ruby`: add explicit `jessie` and `alpine3.4` aliases (docker-library/ruby#142)
- `tomcat`: remove 6 (EOL; https://tomcat.apache.org/tomcat-60-eol.html); downgrade to 9.0.0.M22 and 8.5.16 (http://tomcat.10.x6.nabble.com/Default-servlet-regressions-td5065899.html)
chrissolanilla pushed a commit to chrissolanilla/CSolanillaBio that referenced this pull request May 16, 2024
chrissolanilla pushed a commit to chrissolanilla/CSolanillaBio that referenced this pull request May 16, 2024
Move Ryan.  Fixes docker-library#142

See merge request ucfcdl/static-sites/techrangers-website!186
chrissolanilla pushed a commit to chrissolanilla/CSolanillaBio that referenced this pull request May 16, 2024
Deploy updates

Closes docker-library#142 and docker-library#143

See merge request ucfcdl/static-sites/techrangers-website!188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants