Updated Erlang version to 17.4 #9
Conversation
vovimayhem
force-pushed
the
fix/updated-erlang-version
branch
from
93e0fd0 to
914ca38
Compare
|
Calling it "official" is a bit of a stretch: it's officially endorsed, but it's not run by the Erlang project directly (although it is a neat solution to our issue). http://www.erlang.org/download.html
|
| @@ -3,6 +3,9 @@ FROM debian:wheezy | |||
| # add our user and group first to make sure their IDs get assigned consistently, regardless of whatever dependencies get added | |||
| RUN groupadd -r rabbitmq && useradd -r -d /var/lib/rabbitmq -m -g rabbitmq rabbitmq | |||
|
|
|||
| RUN apt-key adv --keyserver keyserver.ubuntu.com --recv D208507CA14F4FCA | |||
There was a problem hiding this comment.
Can we get the full fingerprint here and use pool.sks-keyservers.net for better reliability?
|
Let me see... |
|
I can add the keys of both Erlang & RabbitMQ in the same apt-key adv command. Should I? |
|
Naw, this is good IMO. 👍 It might be worth adding a link to both the Erlang downloads page that mentions that these packages are endorsed and the downloads page itself, though. |
|
Hey! Sorry, GitHub doesn't tell us when the PR is updated, so we had no idea this was ready for re-review! That comment looks perfect, but I'm puzzled by the unrelated whitespace changes further down? |
| && chmod +x /tmp/rabbitmq-server \ | ||
| && mv /tmp/rabbitmq-server /usr/lib/rabbitmq/lib/rabbitmq_server-*/sbin/rabbitmq-server | ||
| && chmod +x /tmp/rabbitmq-server \ | ||
| && mv /tmp/rabbitmq-server /usr/lib/rabbitmq/lib/rabbitmq_server-*/sbin/rabbitmq-server |
There was a problem hiding this comment.
Can we drop these unrelated whitespace changes?
|
Right away! (The Atom editor messing with whitespaces) |
vovimayhem
force-pushed
the
fix/updated-erlang-version
branch
from
284132a to
7ce5e0f
Compare
|
Ready :) |
|
LGTM! |
|
LGTM |
Updated Erlang version to 17.4
- `docker-dev`: 1.5.0 - `elasticsearch`: 1.3.8 and 1.4.3 - `mongo`: 3.0.0-rc8 - `rabbitmq`: 3.4.4; updated Erlang (docker-library/rabbitmq#9) - `wordpress`: warn if both `WORDPRESS_DB_HOST` and linked MySQL are supplied (docker-library/wordpress#57)
Updated Erlang version to 17.4, installed from the official Erlang debian repo, in case the switch to Debian Jessie can't be done right now.
Fixes #8