Skip to content

Add "procps" back for "rabbitmqctl wait" #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2019

Conversation

tianon
Copy link
Member

@tianon tianon commented Feb 4, 2019

Thanks @bfink13!

(This is a redo of #163, fixing #162, as pointed out in #297 (comment))

@yosifkit yosifkit merged commit 22f6ecb into docker-library:master Feb 4, 2019
@yosifkit yosifkit deleted the procps branch February 4, 2019 21:17
@bfink13
Copy link

bfink13 commented Feb 4, 2019

Thanks for the super fast turnaround! Is the push to docker hub done automatically or manually on a schedule or what?

@tianon
Copy link
Member Author

tianon commented Feb 4, 2019

https://github.com/docker-library/rabbitmq#see-a-change-merged-here-that-doesnt-show-up-on-docker-hub-yet 😉

@gerhard
Copy link
Contributor

gerhard commented Feb 5, 2019

rabbitmqctl wait relies on ps -p

In Ubuntu, this command works out of the box:

docker run --rm ubuntu:18.04 ps -p 1
  PID TTY          TIME CMD
    1 ?        00:00:00 ps

In Alpine, it doesn't:

docker run --rm alpine:3.8 ps -p 1
ps: unrecognized option: p
BusyBox v1.28.4 (2018-12-31 18:05:13 UTC) multi-call binary.

Usage: ps [-o COL1,COL2=HEADER]

Show list of processes

	-o COL1,COL2=HEADER	Select columns for display

Alpine with procps installed:

docker run --rm alpine:3.8 sh -c "apk add procps && ps -p 1"
fetch http://dl-cdn.alpinelinux.org/alpine/v3.8/main/x86_64/APKINDEX.tar.gz
fetch http://dl-cdn.alpinelinux.org/alpine/v3.8/community/x86_64/APKINDEX.tar.gz
(1/6) Installing libintl (0.19.8.1-r2)
(2/6) Installing ncurses-terminfo-base (6.1_p20180818-r1)
(3/6) Installing ncurses-terminfo (6.1_p20180818-r1)
(4/6) Installing ncurses-libs (6.1_p20180818-r1)
(5/6) Installing libproc (3.3.15-r0)
(6/6) Installing procps (3.3.15-r0)
Executing busybox-1.28.4-r3.trigger
OK: 12 MiB in 19 packages
  PID TTY          TIME CMD
    1 ?        00:00:00 ps

I propose we revert ff74887 and add procps to Alpine only.

@tianon
Copy link
Member Author

tianon commented Feb 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants