Rename config0.m4 to config.m4 to avoid phpize failure

[xuhdev]

phpize in docker-php-ext-install would fail if it cannot find config.m4. Some modules, such as zlib, sqlite3 use the name cnofig0.m4 instead of config.m4. This commit performs auto renaming after php is installed.

[md5]

These look related:

• https://bugs.php.net/bug.php?id=21171
• https://bugs.php.net/bug.php?id=53571

[yosifkit]

I think with the bugs linked by @md5, I would be hesitant to change what is a "bug in phpize". Given my reservations, I think we should make it easier for users to phpize these extensions. I would like to see it a little safer (right now it would clobber a config.m4 if both existed). I also wonder if we should do more like one of the bug comments suggested and make a config.m4 file just with includes for any other config files in the directory.

[md5]

@yosifkit Another possibility would be to add all the ones that use config0.m4 to the ./configure. I'm not sure off hand how that would affect image size, but it seems to be what the maintainers recommend in those bugs.

[tianon]

Are there other instances besides just "config0" ? They seem to allude to "config9", etc being possible too.

[md5]

I had assumed that config9 was actually a typo.

[tianon]

"The name actually is part of a simple dependency mechanism for building extensions in the right order." is the part that makes me think it might have been deliberate. Worth trying the "find -name 'config*.m4'" to find out for sure, though.

[md5]

$ docker run -it --rm php find /usr/src/php -name 'config[0-9]*.m4'
/usr/src/php/sapi/cgi/config9.m4
/usr/src/php/ext/openssl/config0.m4
/usr/src/php/ext/recode/config9.m4
/usr/src/php/ext/date/config0.m4
/usr/src/php/ext/pcre/config0.m4
/usr/src/php/ext/libxml/config0.m4
/usr/src/php/ext/zlib/config0.m4
/usr/src/php/ext/ereg/config0.m4
/usr/src/php/ext/sqlite3/config0.m4
/usr/src/php/ext/mysqlnd/config9.m4

Not a typo 👍

[xuhdev]

Ideally if those extensions are configured during php installation, maybe you wanna see the size? I think some of them (sqlite3, pcre, date) are really important.

[yosifkit]

A size difference would be great. Could you make a comparison of enabling the ones we don't already have, that are unable to be phpized, to the current image? Maybe just 5.6 for a start?

[xuhdev]

I applied this patch to the 5.6 CLI version

diff --git a/5.6/Dockerfile b/5.6/Dockerfile
index c8976b3ed5c6..fb3ea3134f8c 100644
--- a/5.6/Dockerfile
+++ b/5.6/Dockerfile
@@ -1,7 +1,7 @@
 FROM debian:jessie

 # persistent / runtime deps
-RUN apt-get update && apt-get install -y ca-certificates curl libxml2 --no-install-recommends && rm -r /var/lib/apt/lists/*
+RUN apt-get update && apt-get install -y ca-certificates curl libpcre3 libxml2 librecode0 --no-install-recommends && rm -r /var/lib/apt/lists/*

 # phpize deps
 RUN apt-get update && apt-get install -y autoconf file gcc libc-dev make pkg-config re2c --no-install-recommends && rm -r /var/lib/apt/lists/*
@@ -21,7 +21,9 @@ RUN buildDeps=" \
                $PHP_EXTRA_BUILD_DEPS \
                bzip2 \
                libcurl4-openssl-dev \
+               libpcre3-dev \
                libreadline6-dev \
+               librecode-dev \
                libssl-dev \
                libxml2-dev \
        " \
@@ -42,7 +44,9 @@ RUN buildDeps=" \
                --enable-mysqlnd \
                --with-curl \
                --with-openssl \
+               --with-pcre \
                --with-readline \
+               --with-recode \
                --with-zlib \
        && make -j"$(nproc)" \
        && make install \

Sizes:

test            406.9 MB
php            405.1 MB

I don't think it's really a problem...

[md5]

@xuhdev 👍

[yosifkit]

That looks great to me 👍.

[md5]

I may check this myself later if I have some time, but are sqlite3 and ereg already enabled somehow?

[xuhdev]

@md5 I think if you didn't add the option --disable-sqlite3, sqlite3 is enabled. I cannot find any option related to ereg though... don't know what it is

[md5]

Thanks @xuhdev 👍

[md5]

Looks like ereg is there even without your changes:

$ docker run -it --rm php php -m | grep ereg
ereg

[yosifkit]

@xuhdev, want to just swap this PR or make a new one to just enabling the couple extensions? 1.8MB is a reasonable amount to me (and won't require changing the source files).

[xuhdev]

@yosifkit Updated the commit. Note that I added the sqlite3 development files (otherwise the sqlite3 extension will not be built) and the size difference increases to 2.7M.

[yosifkit]

LGTM

[tianon]

LGTM