Skip to content

Add alpine variants #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 7, 2016
Merged

Add alpine variants #71

merged 2 commits into from
Dec 7, 2016

Conversation

tianon
Copy link
Member

@tianon tianon commented Dec 6, 2016

Closes #41 (changes carried here -- see first commit)

This includes updates to generate-stackbrew-library.sh, and improves consistency both between Debian and Alpine, and between these Alpine variants and other docker-library Alpine variants. 👍

@tianon
Copy link
Member Author

tianon commented Dec 7, 2016

Argh, assumptions in the test we wrote breaking Travis here -- I'll take a closer look at the tests tomorrow to see if there's a simple fix. 👍

@tianon
Copy link
Member Author

tianon commented Dec 7, 2016

docker-library/official-images@1c9ec7d

https://travis-ci.org/docker-library/logstash/builds/181799642 👍

@yosifkit yosifkit merged commit 1fc7051 into docker-library:master Dec 7, 2016
@yosifkit yosifkit deleted the alpine branch December 7, 2016 22:47
tianon added a commit to infosiftr/stackbrew that referenced this pull request Dec 7, 2016
- `drupal`: 8.2.4
- `logstash`: add `alpine` variants (docker-library/logstash#71)
- `python`: 3.6.0rc1
- `rabbitmq`: allow arbitrary user (docker-library/rabbitmq#125)
@mi-hol
Copy link

mi-hol commented Dec 9, 2016

@tianon I'm a bit lost because #2429 is flagged as merged but
https://github.com/docker-library/repo-info/blob/master/repos/logstash/tag-details.md#logstash502-alpine (need to copy URL string manually due to git bug!)
contains 'does not exist (yet?)'

  1. Any hint how/where I can get the latest alpine based logstash version?
  2. the used tag 'alpine' seems to mean 'latest-alpine', to clarify this purpose I'd recommend to rename it

@tianon
Copy link
Member Author

tianon commented Dec 10, 2016

@mi-hol they should be up now -- they do take a little time to build/push after we merge

The alpine tag is the Alpine variant which corresponds to the latest tag. The reason we don't call it latest-alpine is that latest in Docker is really a misnomer to begin with. Something like default would've been more accurate, since it's simply the tag that is implied if no tag is specified. That being said, we don't recommend that users use :latest (and instead recommend that they depend on a specific version or release track, such as logstash:5.0 or logstash:5), and only provide :latest for the case of not specifying a tag at all, ie, unadorned logstash. Thus, the Alpine-based variant of the logstash image is logstash:alpine, similar to how logstash:5 becomes logstash:5-alpine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants