Skip to content

Conversation

thaJeztah
Copy link
Contributor

the link to the userguide was updated, so updating
it in the hello-world image to save a redirect.

also removed "bash" from the example, because it's
the default for the ubuntu image.

@thaJeztah
Copy link
Contributor Author

ping @tianon I wasn't sure if you wanted to keep the bash in the ubuntu example (or even change it to docker run -it alpine sh), so happy to hear :-)

@tianon
Copy link
Member

tianon commented Apr 26, 2016

Ah nice! I do like keeping bash in here since it helps reinforce the concept of docker run <image> <command> really early on without having to have users think about default commands. 👍

(and I'm also a fan of leaving this on ubuntu specifically because it's a name most users have heard before, so it's a good "second intro image" -- otherwise I would've switched it to debian ages ago 🙈)

@thaJeztah
Copy link
Contributor Author

Yes, I also thought about that; having them run ubuntu once, warms up their image cache for a better experience in further examples. Let me change that line back

the link to the userguide was updated, so updating
it in the hello-world image to save a redirect.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah
Copy link
Contributor Author

updated 👍

@tianon
Copy link
Member

tianon commented Apr 26, 2016

LGTM 👍

Thanks! 😄

@tianon tianon merged commit e0e7d36 into docker-library:master Apr 26, 2016
@thaJeztah thaJeztah deleted the update-url branch April 26, 2016 19:52
tianon added a commit to infosiftr/stackbrew that referenced this pull request Apr 26, 2016
- `cassandra`: 2.2.6 and 2.1.14
- `elasticsearch`: 2.3.2 (docker-library/elasticsearch#101)
- `hello-world`: update userguide link to avoid redirect (docker-library/hello-world#12)
- `java`: 7u101-2.6.6-1~deb8u1 (https://lists.debian.org/debian-security-announce/2016/msg00134.html)
- `logstash`: 2.3.2 (docker-library/logstash#46)
- `mariadb`: fix double install of `mysql-common` (MariaDB/mariadb-docker#56)
- `python`: fix removal of test folders (docker-library/python#102)
- `rocket.chat`: 0.28.0
- `ruby`: 2.3.1 and 2.2.5
- `tomcat`: add Tomcat Native Libraries (docker-library/tomcat#28)
- `wordpress`: 4.5.1
RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
- `cassandra`: 2.2.6 and 2.1.14
- `elasticsearch`: 2.3.2 (docker-library/elasticsearch#101)
- `hello-world`: update userguide link to avoid redirect (docker-library/hello-world#12)
- `java`: 7u101-2.6.6-1~deb8u1 (https://lists.debian.org/debian-security-announce/2016/msg00134.html)
- `logstash`: 2.3.2 (docker-library/logstash#46)
- `mariadb`: fix double install of `mysql-common` (MariaDB/mariadb-docker#56)
- `python`: fix removal of test folders (docker-library/python#102)
- `rocket.chat`: 0.28.0
- `ruby`: 2.3.1 and 2.2.5
- `tomcat`: add Tomcat Native Libraries (docker-library/tomcat#28)
- `wordpress`: 4.5.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants