Skip to content

Specify absolute path to rootlesskit-docker-proxy #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2020
Merged

Specify absolute path to rootlesskit-docker-proxy #231

merged 1 commit into from
May 4, 2020

Conversation

emilytrau
Copy link
Contributor

This fixes #230

@yosifkit
Copy link
Member

😢 Seems like this flag should allow items from PATH, but I guess that would be a Docker bug.

LGTM

@AkihiroSuda
Copy link
Contributor

BTW the latest version should work without this flag to be explicitly specified

@tianon
Copy link
Member

tianon commented May 1, 2020

Yeah, I agree, this sounds like a Docker bug -- I think those flags are supposed to do a PATH lookup (and I think they do for their default values, but maybe not for a custom value?)

If we can just update rootlesskit instead though and remove this flag entirely, I think I'd prefer that solution (but either way it needs to happen in the templates as well or @docker-library-bot will overwrite it).

@AkihiroSuda
Copy link
Contributor

The latest Docker has been already updated not to require this flag

@jappenzesr
Copy link

I have the following error when running a testcase using dockerjava
fork/exec rootlesskit-docker-proxy: no such file or directory

Does this fix apply in this case as well?

More context:

03-May-2020 02:37:49 | 2020-05-03 02:37:49:049 ERROR [main] com/images/gtf-mq:bamboo]:472 - Could not start container
-- | --
03-May-2020 02:37:49 | com.github.dockerjava.api.exception.InternalServerErrorException: {"message":"driver failed programming external connectivity on endpoint adoring_lichterman (07d39e1c171a2067924cb5bff7a41be786ead4f3879d0f39d201d578352a0a82): fork/exec rootlesskit-docker-proxy: no such file or directory"}
03-May-2020 02:37:49 |  
03-May-2020 02:37:49 | at org.testcontainers.dockerclient.transport.okhttp.OkHttpInvocationBuilder.execute(OkHttpInvocationBuilder.java:287)
03-May-2020 02:37:49 | at org.testcontainers.dockerclient.transport.okhttp.OkHttpInvocationBuilder.execute(OkHttpInvocationBuilder.java:265)
03-May-2020 02:37:49 | at org.testcontainers.dockerclient.transport.okhttp.OkHttpInvocationBuilder.post(OkHttpInvocationBuilder.java:126)
03-May-2020 02:37:49 | at com.github.dockerjava.core.exec.StartContainerCmdExec.execute(StartContainerCmdExec.java:28)
03-May-2020 02:37:49 | at com.github.dockerjava.core.exec.StartContainerCmdExec.execute(StartContainerCmdExec.java:11)
03-May-2020 02:37:49 | at com.github.dockerjava.core.exec.AbstrSyncDockerCmdExec.exec(AbstrSyncDockerCmdExec.java:21)
03-May-2020 02:37:49 | at com.github.dockerjava.core.command.AbstrDockerCmd.exec(AbstrDockerCmd.java:35)
03-May-2020 02:37:49 | at com.github.dockerjava.core.command.StartContainerCmdImpl.exec(StartContainerCmdImpl.java:46)
03-May-2020 02:37:49 | at sun.reflect.GeneratedMethodAccessor122.invoke(Unknown Source)
03-May-2020 02:37:49 | at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
03-May-2020 02:37:49 | at java.lang.reflect.Method.invoke(Method.java:498)
03-May-2020 02:37:49 | at org.testcontainers.dockerclient.AuditLoggingDockerClient.lambda$wrappedCommand$14(AuditLoggingDockerClient.java:99)
03-May-2020 02:37:49 | at com.sun.proxy.$Proxy37.exec(Unknown Source)
03-May-2020 02:37:49 | at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:406)
03-May-2020 02:37:49 | at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:317)
03-May-2020 02:37:49 | at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
03-May-2020 02:37:49 | at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:315)
03-May-2020 02:37:49 | at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:302)
03-May-2020 02:37:49 | at org.testcontainers.containers.GenericContainer.starting(GenericContainer.java:1008)
03-May-2020 02:37:49 | at org.testcontainers.containers.FailureDetectingExternalResource$1.evaluate(FailureDetectingExternalResource.java:29)
03-May-2020 02:37:49 | at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)

@AkihiroSuda
Copy link
Contributor

Yes it should, but the right fix is to just remove --userland-proxy-path

@yosifkit yosifkit merged commit 7b00742 into docker-library:master May 4, 2020
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request May 4, 2020
Changes:

- docker-library/docker@7b00742: Merge pull request docker-library/docker#231 from angustrau/fix/rootlesskit-docker-proxy-absolute-path
- docker-library/docker@a73d96e: Remove --userland-proxy-path (no longer necessary)
- docker-library/docker@db82a88: Merge pull request docker-library/docker#232 from docker-library/github-actions
- docker-library/docker@66fafcf: Add initial GitHub Actions CI
@emilytrau emilytrau deleted the fix/rootlesskit-docker-proxy-absolute-path branch May 5, 2020 01:44
tianon pushed a commit to docker-library-bot/official-images that referenced this pull request May 5, 2020
Changes:

- docker-library/docker@7b00742: Merge pull request docker-library/docker#231 from angustrau/fix/rootlesskit-docker-proxy-absolute-path
- docker-library/docker@a73d96e: Remove --userland-proxy-path (no longer necessary)
- docker-library/docker@db82a88: Merge pull request docker-library/docker#232 from docker-library/github-actions
- docker-library/docker@66fafcf: Add initial GitHub Actions CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port expose error when running in dind-rootless
5 participants