This repository was archived by the owner on Sep 12, 2018. It is now read-only.
Fix DISABLE_TOKEN_AUTH flag check in docker_registry/toolkit.py #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we set DISABLE_TOKEN_AUTH to true, there are two functions that should check the flag, but only one function does. Signed-off-by: Guo Xiuyan <[email protected]>
|
Changes Unknown when pulling e682fda on guoxiuyan:Fix_Token_True into * on docker:master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we set DISABLE_TOKEN_AUTH to true, there are two functions that
should check the flag, but only one function does.
So we add the check in both check_token() and validate_parent_access().
Signed-off-by: Guo Xiuyan [email protected]