-
-
Notifications
You must be signed in to change notification settings - Fork 380
Fix link to FuncDeclarator #1764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some things that can help to speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Oh, what is this? |
That's the way. chmgen already does it BTW. |
The idea is to always "reserve" the first comment and update it with helpful information.
Anyways, there's more to come. If you want to change the text -> https://github.com/dlang-bots/dlang-bot/blob/master/source/dlangbot/github.d#L57 |
(Closing & reopening in order to restart the CI.) |
@CyberShadow @wilzbach can you guys add a "Ddoc bug fix" label? The intent is to tag pull requests that fix ddoc errors (such as this one) but don't otherwise deserve a Bugzilla entry. |
@ZombineDev You can add them yourself - click on labels on the pull requests overview list... |
@wilzbach Thanks, not sure how I missed it. |
@CyberShadow any smart idea on easily verifying that all links are valid?
The ugly way would be to parse the generated HTML, create name/id lists for each file and then check all links ...