Skip to content

Conversation

wilzbach
Copy link
Contributor

@CyberShadow any smart idea on easily verifying that all links are valid?
The ugly way would be to parse the generated HTML, create name/id lists for each file and then check all links ...

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 22, 2017

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Some things that can help to speed things up:

  • smaller, focused PRs are easier to review than big ones

  • try not to mix up refactoring or style changes with bug fixes or feature enhancements

  • provide helpful commit messages explaining the rationale behind each change

Bear in mind that large or tricky changes may require multiple rounds of review and revision.

Please see CONTRIBUTING.md for more information.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@CyberShadow
Copy link
Member

Thanks for your pull request, @wilzbach! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.

Oh, what is this?

@CyberShadow
Copy link
Member

The ugly way would be to parse the generated HTML, create name/id lists for each file and then check all links ...

That's the way.

chmgen already does it BTW.

@wilzbach
Copy link
Contributor Author

Oh, what is this?

-> dlang/dlang-bot#44

The idea is to always "reserve" the first comment and update it with helpful information.
We are still at the beginning and it's not super helpful (yet), but this is deployed:

Anyways, there's more to come.

If you want to change the text -> https://github.com/dlang-bots/dlang-bot/blob/master/source/dlangbot/github.d#L57

@PetarKirov
Copy link
Member

(Closing & reopening in order to restart the CI.)

@PetarKirov PetarKirov closed this Jun 23, 2017
@PetarKirov PetarKirov reopened this Jun 23, 2017
@dlang-bot dlang-bot merged commit 0f1594a into dlang:master Jun 24, 2017
@PetarKirov
Copy link
Member

@CyberShadow @wilzbach can you guys add a "Ddoc bug fix" label? The intent is to tag pull requests that fix ddoc errors (such as this one) but don't otherwise deserve a Bugzilla entry.

@wilzbach
Copy link
Contributor Author

@ZombineDev You can add them yourself - click on labels on the pull requests overview list...

@wilzbach wilzbach deleted the fix-invalid-link branch June 24, 2017 09:09
@PetarKirov
Copy link
Member

@wilzbach Thanks, not sure how I missed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants