-
-
Notifications
You must be signed in to change notification settings - Fork 14
Description
Atm the biggest downside imho of the "auto-merge" label system is that the auto-tester doesn't know anything about this status and thus doesn't prioritize "auto-merge" PRs.
@braddr atm the "auto-merge" feature is rather simple and done via labels as follows:
- Only users with write permissions can add labels (this depends on GH not changing their permissions model in the near future)
- There are two labels:
auto-merge
andauto-merge-squash
(the latter will perform a squashed merge) - Dlang-bot has write-access and will do the merge once all required CI status provider pass
@braddr: Is there an easy way to let "labelled" PRs also be prioritized?
The simplest idea that comes to my mind is to let the Dlang-Bot call the auto-toggle API (https://auto-tester.puremagic.com/addv2/toggle_auto_merge
) (and probably disable the GH API request for merge on the auto-tester as (1) the dlang-bot writes the name of the author as part of the merge commit and (2) it probably will fail a lot anyways due to the required CI status checks).
Now I saw that you use a CSRF token for your API. Of course we could scrape the page and thus get a valid token, but I guess you have a better way to let the Bot toggle the auto-merge prioritization?