Skip to content

Conversation

@djluck
Copy link
Owner

@djluck djluck commented Oct 16, 2022

…so disable recycling collectors by default)

@djluck djluck merged commit 4f04cfe into master Oct 16, 2022
@darthkurak
Copy link

WHY?

This is something that broke our production. We had fixed CPU leak, and now it is back.

Shouldn't preprocessor directives be changed to NET5_0_OR_GREATER in this PR?

@darthkurak
Copy link

What's more, it is disabling RecycleCollectorsEvery on net 6 and above - so you don't have the possibility to configure it back. :(

@starkpl
Copy link

starkpl commented Nov 9, 2022

I created a PR with NET5_0_OR_GREATER - this would bring back the recycling when using target net6 and above.
#74

@djluck
Copy link
Owner Author

djluck commented Nov 14, 2022

@darthkurak @starkpl I've just merged and pushed v4.4.0 which restores the ability to optionally enable recycling under .NET 6.0 (it defaults to being off). Have a look and let me know if it helps or not.

@djluck djluck deleted the disable-recycling-net60 branch November 15, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants