Skip to content

Conversation

@ulgens
Copy link
Member

@ulgens ulgens commented Oct 10, 2025

This PR is to trigger the CI to understand the issue with the libsass build. Not intended to be merged.

@ulgens
Copy link
Member Author

ulgens commented Oct 10, 2025

@bmispelon @pauloxnet

  • Prod image builds fail because the OS-level packages I removed for testing are required for psycopg[c], you can ignore that for now.
  • Test image build works fine in CI. My memory about this was that it was failing in CI, but apparently it's not the case.
  • Test image build fails locally with a ARM-family processor, saying
error: command 'gcc' failed: No such file or directory
...
30.57 ERROR: Failed to build installable wheels for some pyproject.toml based projects (libsass)

I think this is the result of Aarch64 wheels being missing and not about Python versions. With the current maintenance status of libsass-python, I don't think this issue will be fixed in a foreseeable future.

libsass is not a blocker for now, and having it doesn't hurt as in a way that matter, but I think this is something we will need to replace soon. Considering libsass itself is deprecated

Warning: LibSass is deprecated. While it will continue to receive maintenance releases indefinitely, there are no plans to add additional features or compatibility with any new CSS or Sass features. Projects that still use it should move onto Dart Sass.

https://github.com/sass/libsass?tab=readme-ov-file#libsass---sass-compiler-written-in-c

We can start looking for alternatives when we have the time / energy.


@dvarrazzo I'm not sure you wanted to be included in this discussion but pinging you for just this once, related to your comment.

@dvarrazzo
Copy link

@ulgens Sorry for the late reply: I am having bandwidth problems... Answered now 🙂

@pauloxnet
Copy link
Member

As I already commented, I will explore the removal of SASS and switch to standard CSS3 i the project.

Comment on lines 31 to 33
RUN apt-get update \
&& apt-get install --assume-yes --no-install-recommends ${BUILD_DEPENDENCIES} \
&& python3 -m pip install --no-cache-dir -r ${REQ_FILE} \
&& apt-get purge --assume-yes --auto-remove ${BUILD_DEPENDENCIES} \
&& apt-get distclean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this is only a draft PR, but when we'll be removing compilation needs for every requirements, we can remove also all apt calls and leave only this line:

RUN python3 -m pip install --no-cache-dir -r ${REQ_FILE}

@adamzap
Copy link
Member

adamzap commented Oct 11, 2025

@pauloxnet Let me know if you want some help removing SASS. I want to as well!

@pauloxnet
Copy link
Member

@pauloxnet Let me know if you want some help removing SASS. I want to as well!

It would be great. 🤗

I'm not sure if @ulgens is already working on the sass removal, otherwise if you want create a draft PR we can then review it.

@ulgens ulgens mentioned this pull request Oct 11, 2025
@ulgens
Copy link
Member Author

ulgens commented Oct 11, 2025

@pauloxnet @adamzap I'm not working on it, and won't be able to. I can help with the cleaning of dependencies tho.

I created an issue to follow this idea and implementation: #2251

@ulgens
Copy link
Member Author

ulgens commented Oct 11, 2025

Now that we have the testing result from CI and #2251 is ready, I'm closing this PR.

@ulgens ulgens closed this Oct 11, 2025
@ulgens ulgens deleted the libsass-build-test branch October 11, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants