-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Remove build dependencies to test libsass #2248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think this is the result of Aarch64 wheels being missing and not about Python versions. With the current maintenance status of libsass-python, I don't think this issue will be fixed in a foreseeable future. libsass is not a blocker for now, and having it doesn't hurt as in a way that matter, but I think this is something we will need to replace soon. Considering libsass itself is deprecated
https://github.com/sass/libsass?tab=readme-ov-file#libsass---sass-compiler-written-in-c We can start looking for alternatives when we have the time / energy. @dvarrazzo I'm not sure you wanted to be included in this discussion but pinging you for just this once, related to your comment. |
|
@ulgens Sorry for the late reply: I am having bandwidth problems... Answered now 🙂 |
|
As I already commented, I will explore the removal of SASS and switch to standard CSS3 i the project. |
| RUN apt-get update \ | ||
| && apt-get install --assume-yes --no-install-recommends ${BUILD_DEPENDENCIES} \ | ||
| && python3 -m pip install --no-cache-dir -r ${REQ_FILE} \ | ||
| && apt-get purge --assume-yes --auto-remove ${BUILD_DEPENDENCIES} \ | ||
| && apt-get distclean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that this is only a draft PR, but when we'll be removing compilation needs for every requirements, we can remove also all apt calls and leave only this line:
RUN python3 -m pip install --no-cache-dir -r ${REQ_FILE}
|
@pauloxnet Let me know if you want some help removing SASS. I want to as well! |
It would be great. 🤗 I'm not sure if @ulgens is already working on the sass removal, otherwise if you want create a draft PR we can then review it. |
|
@pauloxnet @adamzap I'm not working on it, and won't be able to. I can help with the cleaning of dependencies tho. I created an issue to follow this idea and implementation: #2251 |
|
Now that we have the testing result from CI and #2251 is ready, I'm closing this PR. |
This PR is to trigger the CI to understand the issue with the libsass build. Not intended to be merged.