-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Streamlined and added CI steps for docker compose #2207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
0b3585d
Streamline Docker setup and run tests via Docker
tobiasmcnulty 726c7b1
Merge branch 'main' into docker-cleanup
tobiasmcnulty a134253
Merge branch 'main' into docker-cleanup
tobiasmcnulty 03e39ba
Merge branch 'main' into docker-cleanup
tobiasmcnulty a7a672b
Used docker-compose for test build, build-push-action for non-test build
tobiasmcnulty d1cb373
Removed duplicate settings from `docker.py`
tobiasmcnulty 67514f5
Removed unnecessary lines
tobiasmcnulty 68b0b20
Merge branch 'main' into docker-cleanup
tobiasmcnulty 4763370
Merge branch 'main' into docker-cleanup
tobiasmcnulty c3c4bea
Merge branch 'main' into docker-cleanup
tobiasmcnulty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Copied from .gitignore | ||
| __pycache__ | ||
| data | ||
| *.pyc | ||
| *.db | ||
| locale/*/LC_MESSAGES/django.mo | ||
| */locale/*/LC_MESSAGES/django.mo | ||
| .sass-cache/ | ||
| .coverage | ||
| .direnv | ||
| .envrc | ||
| djangoproject/cache | ||
| djangoproject/static/css/*.map | ||
| djangoproject/static/css/*.css | ||
| # Additional ignores for Docker | ||
| .git/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| #!/bin/sh | ||
|
|
||
| PGPASSWORD=secret psql --username=code.djangoproject --dbname=code.djangoproject < /trac.sql |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,7 @@ | ||
| #!/bin/sh | ||
|
|
||
| python -m manage flush --no-input | ||
| PGPASSWORD=secret psql --host db --port 5432 --username=code.djangoproject --dbname=code.djangoproject < tracdb/trac.sql | ||
| python -m manage migrate | ||
| make compile-scss # must come before collectstatic | ||
| python -m manage collectstatic --no-input --clear | ||
| python -m manage loaddata dev_sites | ||
| python -m manage loaddata doc_releases | ||
| # git config --global url."https://".insteadOf git:// | ||
| # python -m manage update_docs | ||
| python -m manage loaddata dashboard_production_metrics | ||
| # python -m manage loaddata dashboard_example_data | ||
| python -m manage update_metrics | ||
|
|
||
| exec "$@" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For production, we just build the image, and then nothing else? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just building the image will be a weak test (and burn CI minutes). Since we are building the image, we might also want to check the startup, something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CuriousLearner Thanks for the feedback. Having some tests for the production image sounds like a positive change to me. I think it could be its own PR as its not really related to the local docker compose setup.