Skip to content

Allow loopback redirect URIs using ports as described in RFC8252 #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 12, 2021
Merged

Allow loopback redirect URIs using ports as described in RFC8252 #953

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
679b00a
Allow loopback redirect URIs using ports as described in RFC8252
pauldekkers Apr 1, 2021
32e618d
Update Changelog and Authors
pauldekkers Apr 4, 2021
6be055f
Docs update and adjustment for explicit port config on loopback
pauldekkers Apr 4, 2021
31f3ca4
Wrap and clarify Changelog
pauldekkers Apr 4, 2021
a410883
Clarify documentation
pauldekkers Apr 4, 2021
659e1a9
Split out redirect uri logic for easier testing
rtpg Apr 5, 2021
bdaead2
Merge branch 'master' into fix/loopback-redirect-uri
auvipy Apr 6, 2021
947a83d
Merge branch 'master' into fix/loopback-redirect-uri
Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions oauth2_provider/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,11 @@ def redirect_uri_allowed(self, uri):
parsed_allowed_uri = urlparse(allowed_uri)

if (
parsed_allowed_uri.scheme == parsed_uri.scheme == "http"
and parsed_uri.hostname in ["127.0.0.1", "::1"]
and parsed_allowed_uri.hostname == parsed_uri.hostname
and parsed_allowed_uri.path == parsed_uri.path
) or (
parsed_allowed_uri.scheme == parsed_uri.scheme
and parsed_allowed_uri.netloc == parsed_uri.netloc
and parsed_allowed_uri.path == parsed_uri.path
Expand Down