Skip to content

Conversation

amureki
Copy link

@amureki amureki commented Mar 10, 2021

Description of the Change

Reverts #937

See the discussion in #937

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@amureki amureki self-assigned this Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #939 (47a0748) into master (062408a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #939   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files          30       30           
  Lines        1423     1423           
=======================================
  Hits         1351     1351           
  Misses         72       72           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 062408a...47a0748. Read the comment docs.

@jezdez
Copy link
Contributor

jezdez commented Mar 10, 2021

Thank you @amureki!

@jezdez jezdez merged commit d6d1f99 into master Mar 10, 2021
@jezdez jezdez deleted the revert-937-gha_smart_run_strategy branch March 10, 2021 11:39
Dylan Giesler
Spencer Carroll
Dulmandakh Sukhbaatar
Rustem Saiargaliev
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been kept :)

Copy link
Author

@amureki amureki Mar 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's alright, I hope I'll get another chance to add something here! 👍

P.S. I realized, that I still have #936 open, will drop a line there. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants