Skip to content

Conversation

@willbeaufoy
Copy link
Contributor

@willbeaufoy willbeaufoy commented Mar 9, 2021

Description of the Change

The existing message to users was 'Application requires following permissions' which sounds
like bad english to me. I've changed them to 'Application requires the following permissions'.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

The existing message to users was 'Application requires following permissions' which sounds
like bad english to me. I've changed them to 'Application requires the following permissions'.
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #935 (4ff1167) into master (4c6f059) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #935   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files          30       30           
  Lines        1423     1423           
=======================================
  Hits         1351     1351           
  Misses         72       72           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c6f059...4ff1167. Read the comment docs.

@n2ygk n2ygk self-requested a review March 9, 2021 20:52
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

Please add yourselves to AUTHORS. No contribution is too small!

@willbeaufoy
Copy link
Contributor Author

Thanks for your contribution!

Please add yourselves to AUTHORS. No contribution is too small!

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants