Skip to content

Conversation

@tevansuk
Copy link
Contributor

@tevansuk tevansuk commented Mar 9, 2021

Description of the Change

Run lint in Github Actions to avoid PRs being merged that have accidentally included linting violations.

Fix a file that has a linting violation.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #933 (01c8d79) into master (ffff6b6) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #933   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files          30       30           
  Lines        1423     1423           
=======================================
  Hits         1351     1351           
  Misses         72       72           
Impacted Files Coverage Δ
oauth2_provider/middleware.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffff6b6...01c8d79. Read the comment docs.

@tevansuk
Copy link
Contributor Author

tevansuk commented Mar 9, 2021

My bad, I should have checked open PRs - I hadn't seen @jezdez had already submitted this. I'll change this to just adding lint to GH actions.

@tevansuk tevansuk force-pushed the fix/move-django-to-main-run-linting-in-gh-actions branch from 898bd68 to bacb950 Compare March 9, 2021 17:26
@tevansuk tevansuk changed the title Use django "main", run lint in GH actions Run "lint" in Github Actions Mar 9, 2021
@jezdez jezdez requested a review from MattBlack85 March 9, 2021 17:36
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for this.

Please rebase tox.ini per #932 that was merged.

Run lint in Github Actions to avoid PRs being merged that have
accidentally included linting violations.

Fix a file that has a linting violation.
@tevansuk tevansuk force-pushed the fix/move-django-to-main-run-linting-in-gh-actions branch from bacb950 to 01c8d79 Compare March 9, 2021 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants