pass PKCE fields to AuthorizationView form #896
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
first of all thanks for developing and maintaining a great project!
Description of the Change
Pass
code_challengeandcode_challenge_methodfrom query string toAuthorizationViewform inget().Without this, it was impossible to use authorization code grant flow with
GET, becausecode_challengeandcode_challenge_methoddata were never passed to form, so they weren't inform.cleaned_data, which causes creatingGrantwith always emptycode_challengeandcode_challenge_method.This issue was quite hard bug to discover because there are already few tests for authorization code flow pkce, however, they weren't checking form rendering in
GETrequest, but onlyresponse.status_code, I have added asserts for these 2 values, please look at the changes intest_public_pkce_plain_authorize_getandtest_public_pkce_S256_authorize_gettests intest_authorization_code.py.Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS