Skip to content

Conversation

@sassanh
Copy link
Contributor

@sassanh sassanh commented Jun 22, 2018

If a request's body is a json list instead of a json object django-oauth-toolkit raises and exception. It breaks bulk requests for drf for example. This commit fixes it.

If a request's body is a json list instead of a json object django-oauth-toolkit raises and exception. It breaks bulk requests for drf for example. This commit fixes it.
@sassanh
Copy link
Contributor Author

sassanh commented Jun 22, 2018

Discussed here: #456

@coveralls
Copy link

Pull Request Test Coverage Report for Build 929

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-60.5%) to 32.568%

Totals Coverage Status
Change from base Build 923: -60.5%
Covered Lines: 383
Relevant Lines: 1176

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 22, 2018

Pull Request Test Coverage Report for Build 930

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.931%

Totals Coverage Status
Change from base Build 923: -0.1%
Covered Lines: 1170
Relevant Lines: 1259

💛 - Coveralls

@sassanh sassanh merged commit 99b4763 into django-oauth:master Jun 22, 2018
@sassanh
Copy link
Contributor Author

sassanh commented Jun 22, 2018

Related issues:
#398
#466

@jezdez
Copy link
Contributor

jezdez commented Jun 26, 2018

@sassanh Please make sure to let other members review your pull requests and don't merge them automatically.

@sassanh
Copy link
Contributor Author

sassanh commented Jun 26, 2018

@jezdez this PR was reviewed here: #456 I just created a new one to clean it up.

@jezdez
Copy link
Contributor

jezdez commented Jun 26, 2018

@sassanh Ah, excellent, that wasn't mentioned specifically here or there and someone raised the behavior correctly in #610. Please make sure to make cross-references when you open PRs as new ones. I guess the reasoning was because #456 was opened against an "unknown branch" (your fork)?

@sassanh
Copy link
Contributor Author

sassanh commented Jun 26, 2018

@jezdez No I just thought there are lots of unnecessary commits (3) for such a simple change. So I tried to clean up the main PR but I failed so I created another one.
I'll make sure I won't merge a PR on jazzband unless it has reviews.

@jezdez
Copy link
Contributor

jezdez commented Jun 26, 2018

@sassanh Gotcha, thanks!

@n2ygk
Copy link
Contributor

n2ygk commented Mar 1, 2020

@jleclanche @jezdez Bringing this back up as I don't see an independent review approval for this commit. I'm trying to figure out how to document this issue for the 1.3.0 release (#785) since there was no CHANGELOG entry created. I'd appreciate a quick second look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants