-
Notifications
You must be signed in to change notification settings - Fork 814
Issue #196 Add permission checking to application registration #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ation Add an addition setting called APPLICATION_REGISTRATION_PERMISSIONS which controls which permissions must be set on a user to allow the creation of applications. By default (in this PR) this is the 'add_application' permission which regretfully is not backwards compatible but it does seem to make the most sense from a security perspective as a default. Reverting to the old behaviour is easily done by using None for the settings key.
2 similar comments
HI @trbs, I'd prefer to leave the default behavior unchanged, so the app is backwards compatible. Can you add some docs for the settings APPLICATION_REGISTRATION_PERMISSIONS with an example and some specifc tests? Thanks a lot for your effort |
1 similar comment
@synasius the default is now backwards compatible and I put the old settings as the example in the documentation. Two extra tests now test creating an application with and without the correct permission. |
docs/settings.rst
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/none/non/
… users or users with add_application permission
Isn't it better to have a configurable callback that tests if user has rights to create apps? Originally it won't be defined and would do nothing but in real life experience one can supply own callback which will receive lets say |
Add an addition setting called APPLICATION_REGISTRATION_PERMISSIONS
which controls which permissions must be set on a user to allow the
creation of applications.
By default (in this PR) this is the 'add_application' permission which
regretfully is not backwards compatible but it does seem to make the
most sense from a security perspective as a default.
Reverting to the old behaviour is easily done by using None for the
settings key.