Allow arbitrary schemes within HttpResponseRedirect() #187
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redirect_uri
is supposed to handle arbitrary schemes as per the RFC; this is especially useful for mobile app handlers eg.mobile-app://my/callback?code=...
.To this end, this PR implements
UnsafeHttpResponseRedirect
inoauth2_provider/views/http.py
that does the same thing asHttpResponseRedirect
except it does not check the scheme, as it is already done in the various validators.It's a shame there is no base class in
django.http
to do the Location header stuff without the check, but anyway.A test has been added to check this bugfix.
See #154 and #155 for discussions regarding the validation of the
redirect_uri
field iself.