Skip to content

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Jan 3, 2023

Description of the Change

Replaces deprecated tox.ini whitelist_externals with allowlist_externals. This is breaking any new PR as of the tox version upgrade.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk requested a review from a team January 3, 2023 15:35
@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #1241 (320efad) into master (04b5b3e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1241   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files          31       31           
  Lines        1821     1821           
=======================================
  Hits         1766     1766           
  Misses         55       55           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@dopry dopry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a tox version as a dev dependency or at least mention the minimum supported tox version in out developer docs?

@n2ygk
Copy link
Contributor Author

n2ygk commented Jan 4, 2023

@dopry allowlist_externals has been supported by tox since 2020 so I don't think it's necessary to document the version requirement.

Copy link
Member

@dopry dopry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++good.

@dopry dopry merged commit c02d4e4 into django-oauth:master Jan 4, 2023
@n2ygk n2ygk added this to the Future milestone Feb 12, 2023
@n2ygk n2ygk modified the milestones: Future, 2.3.0 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants