Skip to content

Conversation

variable
Copy link

@variable variable commented May 1, 2014

When using django_allauth, the max_length of secret field is 100, however the generated secret string is hardcoded to 128. This commit allows configurable generated secret string lengths.

@variable
Copy link
Author

variable commented May 1, 2014

Travis failed on python 3 interpreter not found

@palazzem
Copy link
Contributor

palazzem commented Jul 3, 2014

Hi @variable,
it's ok for us to provide a configurable secret_id length for our ClientSecretGenerator.

However I can't merge this pull request cause of fc7b99a commit which is
out of pull request scope (and this is already have been merged).

So I've cherry-picked your commit. Thanks for your code!

@palazzem palazzem closed this Jul 3, 2014
@masci masci added this to the 0.8.0 milestone Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants