Do not allow hashed secret to be passed in via client #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n2ygk
requested changes
Jan 8, 2022
| * #651 Batch expired token deletions in `cleartokens` management command | ||
| * Added pt-BR translations. | ||
| * #729 Add support for [hashed client_secret values](https://django-oauth-toolkit.readthedocs.io/en/latest/settings.html#client-secret-hasher). | ||
| * #1077 Bug fix for hashed client secrets |
There was a problem hiding this comment.
No need for an added changelog entry here as it's just a bug fix for a feature that has not yet been released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1077
Description of the Change
Fixes bug by checking both client and server strings for the same
$sentinel character.Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS