Skip to content
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions example/tests/test_model_viewsets.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,24 @@ def test_patch_requires_id(self):

self.assertEqual(response.status_code, 400)

def test_patch_requires_correct_id(self):
"""
Verify that 'id' is required to be passed in an update request.
"""
data = {
'data': {
'type': 'users',
'id': 3,
'attributes': {
'first-name': 'DifferentName'
}
}
}

response = self.client.patch(self.detail_url, data=data)

self.assertEqual(response.status_code, 409)

def test_key_in_post(self):
"""
Ensure a key is in the post.
Expand Down
10 changes: 10 additions & 0 deletions rest_framework_json_api/parsers.py
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,16 @@ def parse(self, stream, media_type=None, parser_context=None):
if not data.get('id') and request.method in ('PATCH', 'PUT'):
raise ParseError("The resource identifier object must contain an 'id' member")

if request.method in ('PATCH', 'PUT'):
kwarg_name = view.lookup_url_kwarg if view.lookup_url_kwarg else view.lookup_field
if str(data.get('id')) != str(view.kwargs[kwarg_name]):
raise exceptions.Conflict(
"The resource object's id ({data_id}) does not match url ({url_id})".format(
data_id=data.get('id'),
url_id=view.kwargs[view.lookup_field]
)
)

# Construct the return data
serializer_class = getattr(view, 'serializer_class', None)
parsed_data = {'id': data.get('id')} if 'id' in data else {}
Expand Down