Pin django-debug-toolbar version to fix Python 2.7 tests #634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
=======================================
Coverage 95.66% 95.66%
=======================================
Files 56 56
Lines 2861 2861
=======================================
Hits 2737 2737
Misses 124 124Continue to review full report at Codecov.
|
This was referenced May 22, 2019
n2ygk
approved these changes
May 24, 2019
Contributor
n2ygk
left a comment
n2ygk
left a comment
There was a problem hiding this comment.
Ah, I see it was pinned in requirements-development.txt but not here. LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Pin django debug toolbar to fix tests in master.
This is a quick fix and at a later point we should try to avoid having debug toolbar as dependency for tests. A bit more complicated to fix as example and tests are combined.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS