Skip to content

Correct error responses for projects with different DRF-configurations #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 14, 2016
Merged

Correct error responses for projects with different DRF-configurations #222

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4bd759a
[#214] Add error messages tests.
riklaunim Apr 8, 2016
87723e5
[#214] Extract formatting DRF errors.
riklaunim Apr 8, 2016
a8d71df
Add example view with custom handle_exception.
riklaunim Apr 11, 2016
e2cdf30
Use HTTP 422 for validation error responses.
riklaunim Apr 11, 2016
7b539e7
Refactor.
riklaunim Apr 13, 2016
0cf0cd8
Add full example of class-configured json api view.
riklaunim Apr 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions example/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,22 @@
from example.serializers import (
BlogSerializer, EntrySerializer, AuthorSerializer, CommentSerializer)

from rest_framework_json_api.utils import format_drf_errors


class BlogViewSet(viewsets.ModelViewSet):
queryset = Blog.objects.all()
serializer_class = BlogSerializer


class BlogCustomViewSet(viewsets.ModelViewSet):
queryset = Blog.objects.all()
serializer_class = BlogSerializer

def handle_exception(self, exc):
return format_drf_errors(super(BlogCustomViewSet, self).handle_exception(exc), self.get_exception_handler_context(), exc)
Copy link
Member

@jerel jerel Apr 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split this into multiple lines, it's a bit long.

Also would you mind adding some comments to this function so devs reading this file for an example can easily understand that it is an optional override that enables JSON-API to work alongside the regular DRF format?

Copy link
Contributor Author

@riklaunim riklaunim Apr 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do. I'll also add the other settings that can be set on the class itself - as a full setup example.



class EntryViewSet(viewsets.ModelViewSet):
queryset = Entry.objects.all()
resource_name = 'posts'
Expand Down