Skip to content

Conversation

@jong-seoung
Copy link
Contributor

Description

Since the installation instructions in the example/readme were insufficient, I modified it to use requirements.txt for installation instead of directly using Django.

Fixes #1949

Checklist:

  • I have added the relevant tests for this change.
  • I have added an item to the Pending section of docs/changes.rst.

Copy link
Member

@tim-schilling tim-schilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally in favor of this change. My suggestion is a minor grammatical change.

Co-authored-by: Tim Schilling <[email protected]>
@matthiask matthiask merged commit 7f18cf5 into django-commons:main Nov 5, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jinja2 dependency breaks default install

3 participants