Apply UP006 and UP035 changes from pyupgrade pre-commit hook #2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulgens
changed the title
Member
|
Makes sense, thanks. I thought the pre-commit CI runs, but it obviously does not! |
Member
|
I reconnected pre-commit.ci with the repository since the CI thing was lost when moving away from Jazzband. |
Member
Author
|
@matthiask Thanks for the fix. How can we see the build output for pre-commit hooks, or at least a log that shows it's working? |
Member
|
@ulgens GitHub doesn't seem to link to the output anymore after merging, but there you go: https://results.pre-commit.ci/run/github/46939/1730393311.cldDtEpORou_PEjJom970A |
Member
Author
|
@matthiask Thanks for the link. I don't use the external service at all, so I have no idea how to fix these issues but please let me know if it's something I can help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UP006: https://docs.astral.sh/ruff/rules/non-pep585-annotation/
UP035: https://docs.astral.sh/ruff/rules/deprecated-import/
Description
pre-commitoutput on the main branch wasn't clean. Runpre-commit run --all-filesand applied the resulting fixes.The ideal solution here would be to have
pre-commitrunning in the CI. I can use some recommendations to handle that with tox.