Remove signed_data_view decorator to support url type checking. #1658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package django-urlconfchecks was erroring on the toolbar's URLs because signed_data_view was injecting an extra parameter for the views. The alternative to the decorator isn't terrible so let's use that instead. Eventually this can be shortened with the walrus operator when py37 support is dropped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package django-urlconfchecks was erroring on the toolbar's
URLs because signed_data_view was injecting an extra parameter
for the views. The alternative to the decorator isn't terrible
so let's use that instead. Eventually this can be shortened
with the walrus operator when py37 support is dropped.
This is an alternative to #1657