Use only pre-commit for style linters and fixers #1535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method of using the `Makefile`, running under `tox`, duplicated the work of pre-commit and pre-commit.ci. Additionally tox did not use the same pinned versions and arguments as in `.pre-commit-config.yaml`, so there is the potential for a version clash to cause the two paths to conflict, e.g. when a new version of Black is released. Sticking to only `pre-commit` seems sensible, saves some CI time, and allows some files to be removed.
Codecov Report
@@ Coverage Diff @@
## main #1535 +/- ##
=======================================
Coverage 85.71% 85.71%
=======================================
Files 35 35
Lines 1883 1883
Branches 274 274
=======================================
Hits 1614 1614
Misses 190 190
Partials 79 79
Continue to review full report at Codecov.
|
|
Thanks! I like this very much. I always forgot how to run the Makefile commands anyway... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method of using the
Makefile, running undertox, duplicated the work of pre-commit and pre-commit.ci. Additionally tox did not use the same pinned versions and arguments as in.pre-commit-config.yaml, so there is the potential for a version clash to cause the two paths to conflict, e.g. when a new version of Black is released.Sticking to only
pre-commitseems sensible, saves some CI time, and allows some files to be removed.