Skip to content

Conversation

@ngnpope
Copy link
Contributor

@ngnpope ngnpope commented Nov 2, 2020

I looked through the signals documentation and added some of the missing ones: m2m_changed, pre_migrate, and setting_changed.

Note that setting_changed comes under the test signals, but says that it can be imported from django.core.signals. I left out template_rendered as it is "only available during testing".

There are also django.contrib.auth.signals. I don't think adding them here would make a hard dependency on django.contrib.auth so they could be added?

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #1397 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1397      +/-   ##
==========================================
- Coverage   87.88%   87.81%   -0.07%     
==========================================
  Files          29       29              
  Lines        1576     1576              
  Branches      221      221              
==========================================
- Hits         1385     1384       -1     
- Misses        141      143       +2     
+ Partials       50       49       -1     
Impacted Files Coverage Δ
debug_toolbar/panels/signals.py 86.36% <100.00%> (+4.54%) ⬆️
debug_toolbar/panels/profiling.py 86.60% <0.00%> (-2.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 019eb7f...426c900. Read the comment docs.

@matthiask
Copy link
Member

Thanks!

@matthiask matthiask merged commit dfc863e into django-commons:master Nov 3, 2020
@ngnpope ngnpope deleted the missing-signals branch November 3, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants