Fix #1184 -- Replace loading gif with css animation #1353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdufresne
reviewed
Sep 29, 2020
jdufresne
approved these changes
Sep 30, 2020
Contributor
jdufresne
left a comment
jdufresne
left a comment
There was a problem hiding this comment.
Nice! This is really neat. Thanks for contributing it.
Contributor
Author
|
@jdufresne I removed the display property as suggested. I guess you are most familiar with the merge and release proceedings. I'd leave that to you, if that's ok. |
Member
|
Thank you, that's awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can test it by loading a page, then disabling the network in the browsers debug console followed by opening any toolbar tab.
The whole thing looks like this:
