Load JavaScript as ES6 modules #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1283 +/- ##
=======================================
Coverage 86.61% 86.61%
=======================================
Files 25 25
Lines 1449 1449
Branches 205 205
=======================================
Hits 1255 1255
Misses 142 142
Partials 52 52 Continue to review full report at Codecov.
|
JavaScript modules have been supported by the spec since ES6 (2015) and the feature is available in all modern, supported browsers. Using JavaScript modules offers advantages: - All scripts are loaded in strict mode, reducing unexpected edge cases from "sloppy mode". - Scripts run in isolation and no longer pollute the global namespace. This allows removing the IIFE from all JavaScript. - Browsers can optimize loading of modules. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript modules have been supported by the spec since ES6 (2015) and
the feature is available in all modern, supported browsers.
Using JavaScript modules offers advantages:
All scripts are loaded in strict mode, reducing unexpected edge cases
from "sloppy mode".
Scripts run in isolation and no longer pollute the global namespace.
This allows removing the IIFE from all JavaScript.
Browsers can optimize loading of modules.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Modules